Skip to content

[-]: 키보드 및 닫기 제어 옵션 추가#6

Merged
sjsjsj1246 merged 1 commit into
mainfrom
codex/add-keyboard-and-close-controls
Mar 24, 2026
Merged

[-]: 키보드 및 닫기 제어 옵션 추가#6
sjsjsj1246 merged 1 commit into
mainfrom
codex/add-keyboard-and-close-controls

Conversation

@sjsjsj1246
Copy link
Copy Markdown
Owner

변경 사항

  • OptionskeyboardNavigation, closeOnOverlayClick 옵션을 추가했습니다.
  • overlay가 열려 있을 때만 Escape/ArrowLeft/ArrowRight를 처리하고, 텍스트 입력 포커스 중에는 단축키를 무시합니다.
  • backdrop click close 동작을 opt-in으로 추가하고 README/docs 예제와 테스트를 갱신했습니다.

테스트

  • pnpm -C packages/main test
  • pnpm -C packages/document build
  • pnpm build

남은 리스크

  • 단축키 예외 처리는 input/textarea/select/contenteditable에 한정되어 있어 특수 커스텀 편집기 대응은 별도 검토가 필요합니다.
  • highlight padding이나 info box 위치 보정 같은 overlay geometry 개선은 이번 범위에 포함하지 않았습니다.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-tutorial-overlay Ready Ready Preview, Comment Mar 24, 2026 2:22pm

@sjsjsj1246 sjsjsj1246 self-assigned this Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

packages/main coverage

Metric Result
Lines 94.18% (162/172)
Statements 93.82% (167/178)
Functions 85.29% (29/34)
Branches 79.56% (109/137)

Workflow run

@sjsjsj1246 sjsjsj1246 merged commit b3a3789 into main Mar 24, 2026
3 checks passed
@sjsjsj1246 sjsjsj1246 deleted the codex/add-keyboard-and-close-controls branch March 24, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant